search

jjethwa / rundeck

GNU General Public License v3.0
122 stars 137 forks source link

Fixes #36 #37

Closed amontalban closed 8 years ago

amontalban commented 8 years ago

Fixes #36

jjethwa commented 8 years ago

Thanks so much @amontalban

More configuration options is always a good thing :)

jjethwa commented 8 years ago

Hi @amontalban

I need to revert this merge. I should have reviewed it a bit more. Looks like it's causing an issue for users with local MySQL instances Probably one of the seds needs to be updated

amontalban commented 8 years ago

Hi @jjethwa

Sorry to hear that, I'm going to give it a more deep test and let you know.

Thanks!

jjethwa commented 8 years ago

@amontalban

No problem at all and thanks :)

amontalban commented 8 years ago

Hi @jjethwa

Do you have more info about the issue you said above? Because seems to be working for me.

I'm thinking that maybe the issue was with the changed parameters, say RUNDECK_PASSWORD with DATABASE_PASSSWORD?

Thanks!

jjethwa commented 8 years ago

Hi @amontalban

Unfortunately, I had to revert your other PRs too to get us back to the previous state cleanly without having to edit things manually. Sorry for the extra work :(

For this PR, I think we'll need to keep support for the old env vars like RUNDECK_PASSWORD, but add a note in the readme and an echo in the run script to let users know that the old variables are deprecated so they know to move to the new ones you've added. I made a bad choice with the naming conventions when I started, your convention is a lot easier for new users to understand without looking at the readme.

I haven't had a chance to look into what the issue was, but for users using the local MySQL DB, they had this exception in the rundeck service.log:

java.sql.SQLException: Access denied for user 'rundeck'@'localhost' (using password: YES)

So maybe an issue with the rundeck user not having it's password updated in MySQL or the password not getting updated in the properties file?

jjethwa commented 7 years ago

Hi @amontalban

I'm back from vacation :) There was another PR to reduce the layers and it's been merged already to dev and master. If you have time, are you interested in looking into your 3 PRs again? :)

amontalban commented 7 years ago

Hi @jjethwa,

Sure I will try to find some time to do it as we had to put this project aside in our env.

Will let you know once they are ready.

Thanks!