search

jjethwa / rundeck

GNU General Public License v3.0
122 stars 137 forks source link

Slim the container, add sha256 file verification on external files #46

Closed adamdecaf closed 7 years ago

adamdecaf commented 8 years ago

Hey!

I saw there was another recent attempt to slim this container, but that was reverted. I'm not sure why, but I figured I'd offer an attempt at slimming.

This change also includes sha256 verification of the files pulled from external sources.

New: 611.1 MB, Old: 753 MB

jjethwa commented 8 years ago

Hi @adamdecaf

Thanks so much! I am on vacation and away from my test setup, so I'll wait to merge your PR until I'm back. I had to revert the previous PRs as one of them introduced a change that caused issues for users using the existing environment variables. Really appreciate the PR and look forward to merging it soon :)

jjethwa commented 7 years ago

Hi @adamdecaf

I sent another PR to the dev branch ( https://github.com/jjethwa/rundeck/tree/dev ) and am in the process of testing it out. I removed the autoremove line as I want to keep curl and git as part of the install as users may already expect those utils to be included. I also bumped rundeck-cli to the latest version. You can pull dev branch from docker hub if you want to test it out as well.

adamdecaf commented 7 years ago

I removed the autoremove line as I want to keep curl and git as part of the install as users may already expect those utils to be included.

Sounds good.