search

jjethwa / rundeck

GNU General Public License v3.0
122 stars 137 forks source link

Adding more env vars and fixed issue with tmp folder #60

Closed anojansivarajah closed 7 years ago

anojansivarajah commented 7 years ago

Added more environment variables to facilitate LDAP authentication and SSL certificates. Also fixed a bug with changing UID and GID by deleting and re-creating /tmp/rundeck folder

jjethwa commented 7 years ago

Hi @anojansivarajah-awin

Thanks so much for the PR! 😄

There are a few changes I'd like you to take a look and comment on. I'll add them to the lines in question.

anojansivarajah commented 7 years ago

Please let me know the lines and I'll add the explanation. Thanks

anojansivarajah commented 7 years ago

Any luck yet?

jjethwa commented 7 years ago

Hi @anojansivarajah

I don't see any updates yet. Check the comments under: https://github.com/jjethwa/rundeck/pull/60/files

anojansivarajah commented 7 years ago

@jjethwa I'm sorry, i can see only your reaction to couple of my comments. Am I missing to see something? I can't see any of your comments :(

jjethwa commented 7 years ago

Hi @anojansivarajah

Sorry about that! It was my fault. I forgot to submit the review 😢 You should be able to see it now. If not, let me know and I'll write it up here.

anojansivarajah commented 7 years ago

Hi @jjethwa, Please let me know your thoughts. Thanks

jjethwa commented 7 years ago

Thanks @anojansivarajah

Looks good! You didn't have to skip out on the pub for this hehe. Merging now 😄