Closed anojansivarajah closed 7 years ago
Hi @anojansivarajah-awin
Thanks so much for the PR! 😄
There are a few changes I'd like you to take a look and comment on. I'll add them to the lines in question.
Please let me know the lines and I'll add the explanation. Thanks
Any luck yet?
Hi @anojansivarajah
I don't see any updates yet. Check the comments under: https://github.com/jjethwa/rundeck/pull/60/files
@jjethwa I'm sorry, i can see only your reaction to couple of my comments. Am I missing to see something? I can't see any of your comments :(
Hi @anojansivarajah
Sorry about that! It was my fault. I forgot to submit the review 😢 You should be able to see it now. If not, let me know and I'll write it up here.
Hi @jjethwa, Please let me know your thoughts. Thanks
Thanks @anojansivarajah
Looks good! You didn't have to skip out on the pub for this hehe. Merging now 😄
Added more environment variables to facilitate LDAP authentication and SSL certificates. Also fixed a bug with changing UID and GID by deleting and re-creating /tmp/rundeck folder