jjethwa / rundeck

GNU General Public License v3.0
123 stars 137 forks source link

Allow Brand HTML to be set via an environment variable #73

Closed eugeneduvenage closed 7 years ago

eugeneduvenage commented 7 years ago

Hi,

When deploying many rundeck containers into an environment it is useful to set the brand html via the rundeck.gui.brand.html property to set a visual reminder of the rundeck target environment (in the rundeck-config.properties file).

I propose adding an environment variable GUI_BRAND_HTML which can set this property within the /opt/run script. I have working code in a branch at https://github.com/eugeneduvenage/rundeck/tree/set-brand-via-env which does the following:

If you are happy with the proposal I can submit a pull request.

Regards, Eugene Duvenage

jjethwa commented 7 years ago

Hi @eugeneduvenage

Sounds great! Please send a PR when you have time. Does the HTML string need to be encapsulated by quotes?

jjethwa commented 7 years ago

Thanks for the PR @eugeneduvenage

Just merged the PR. It'll be in the latest version of the container on Docker Hub in a few minutes 😄