allow omission of EXTERNAL_RUNDECK_URL; formatting code

[ddavison]

Summation of changes:

• Defaulted the grails.serverURL to be omitted
• Rundeck defaults will always be put in. Before, it was checking /etc/rundeck for existence. If it found this directory, then it would skip. The reason for this change is for idempotence.
• Reformatted code. We previously had three spaces, instead of the standard "two" spaces. This is why so many lines had been changed.

Problem description:

When launching the jordan/rundeck container from an orchestration tool like Kubernetes, OpenShift or AppOrbit; The image is given a dynamic IP of hosts to host from. Rundeck's grails.serverURL controls how grails will redirect the application. When this property is commented out, rundeck refuses to forcibly redirect and leaves it to relative pathing.

Examples:

Before change

$ docker run -p 4440:4440 -e SERVER_URL=http://localhost:4440

After logging in, a header is sent from rundeck to redirect to "http://localhost:4440. fine. If this container was launched from AppOrbit, or another orchestration tool that dynamically assigns the IP, the IP can be impossible to obtain. Therefore, rundeck would attempt to redirect to an invalid ip/host.

After change

$ docker run -p 4440:4440 -e SERVER_URL=http://localhost:4440
$ docker exec -it ... cat /etc/rundeck/rundeck-config.properties
...
#grails.serverURL=
...

# With grails.serverURL commented out, rundeck will no longer forcibly redirect and fall back to relative pathing.

$ docker run -p 4440:4440 -e SERVER_URL=http://localhost:4440 -e EXTERNAL_SERVER_URL=http://test:4440
$ docker exec -it ... cat /etc/rundeck/rundeck-config.properties
...
grails.serverURL=http://test:4440
...

# We are able to provide EXTERNAL_SERVER_URL when applicable

I've tested this thoroughly and validates that this indeed works.

Source material:

• It should always be safe to remove the serverURL property and let Grails generate urls relative to the current running app.
• https://github.com/voxpupuli/puppet-rundeck/issues/40#issuecomment-85817344
• https://github.com/rundeck/rundeck/issues/671#issuecomment-44187035

There could be unknown side-effects of this change, however the ability for the explicit setting of EXTERNAL_SERVER_URL should bypass any of those cases.

[jjethwa]

Thanks so much, @ddavison

Is there any way you can update the PR to include only the necessary changes? The space/tab changes are making it a bit hard to sort through. Really appreciate it 👍

[ddavison]

sure thing! unfortunately i forgot to separate the commits.. so give me a bit :face_with_head_bandage:

[ddavison]

should be a bit more readable now. a couple spacing fixes were unintentionally left in there, as well as blank lines.

[jjethwa]

Thanks, @ddavison

Looks good! 😄

[jjethwa]

Hi @ddavison

I received an issue and some offline complaints about configs getting replaced due to the /etc/rundeck check being removed, so I've added it back in for now. Do you see any problems with having it back in that would affect your work? Thanks 😄

[ddavison]

yea no, that's fine! honestly, in retrospect - it was kind of a destructive change that i probably should not have put in. no worries though. all is well.

[jjethwa]

Great! Thanks for confirming, @ddavison I had missed it during the PR merge 😛