64 bit consts - Githubissues

jjfiv / dalvik-js

Project for CS 691ST - Dalvik VM implementation in Javascript

23 stars 11 forks source link

64 bit consts #64

Closed jen4ik closed 12 years ago

jen4ik commented 12 years ago

opCodes 0x16, 0x17, 0x18 and 0x19 take a 64 bit value and put it in a register. Do we have something to pull such large values? Do we want a get64() function or just use get32 twice?

jjfiv commented 12 years ago

Either way. If you want to make an ArrayFile.prototype.get64, it will probably call get32 twice inside, and then pass it to a gLong... I don't know what the method is called to make a gLong from two 32-bit pieces, but I'm sure there is one.

jen4ik commented 12 years ago

OK I just pushed an update to gitHub, can you take a look and see if it makes sense? 0x18, 0x19

jen4ik commented 12 years ago

finished