search

jjfiv / dalvik-js

Project for CS 691ST - Dalvik VM implementation in Javascript
23 stars 11 forks source link

MethodSignature.prototype.isMain needs to be more specific #78

Closed jjfiv closed 12 years ago

jjfiv commented 12 years ago

Right now it just compares names, but in java a main(V)V is not a valid entry point. We need to check the return type and the parameter types.

jen4ik commented 12 years ago

Why would it return "this._name" and not true or false?

jen4ik commented 12 years ago

Or was it just a stub and it's a very silly question? (:

etosch commented 12 years ago

Are you sure you're looking at the right method? MethodSignature::isMain returns a boolean; MethodSignature::getName is immediately below it and returns this._name

jjfiv commented 12 years ago

Update: making this more type specific has created some problems in vmtest; Jennie is looking into it.