search

jjfiv / dalvik-js

Project for CS 691ST - Dalvik VM implementation in Javascript
23 stars 11 forks source link

make invoke less hideous #89

Closed etosch closed 11 years ago

jjfiv commented 11 years ago

Maybe a part of #91

etosch commented 11 years ago

Yeah...I almost think that, given the scale of what this might become, we ought to kick it to another file, like an invoke.js.

etosch commented 11 years ago

@jjfiv - priority on this? Also, could you send a mail on tasks/priorities? Doesn't need to be too soon - focus on getting your IR stuff done. I can also do this tomorrow morning, if you let me know what you think the top goal in the next 24 hours is.

jjfiv commented 11 years ago

Invoke is less hideous now that it's in its own file, I believe? @etosch

etosch commented 11 years ago

No, it's still abominable. The others might want to weigh in on its readability.

On Wed, Oct 31, 2012 at 12:29 PM, John Foley notifications@github.comwrote:

Invoke is less hideous now that it's in its own file, I believe? @etosch https://github.com/etosch

— Reply to this email directly or view it on GitHubhttps://github.com/jjfiv/dalvik-js/issues/89#issuecomment-9951617.

Emma Tosch Graduate Research Assistant, Computational Intelligence Lab, Hampshire College MS/PhD student, University of Massachusetts, Amherst etosch@cs.umass.edu http://cs.umass.edu/~etosch

jjfiv commented 11 years ago

Invoke was an ugly duckling, but matured into a beautiful swan.