search

jjfreedman / bullet

Automatically exported from code.google.com/p/bullet
Other
0 stars 0 forks source link

fixing warnings: string literals as const, out-of-order member initializations, and printf of size_t should use %zu #537

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This patch fixes a number of warnings regarding:
* character strings (should be const)
* constructor member initialization lists should match declaration order
* printf format strings should use %zu for size_t

Original issue reported on code.google.com by ejtt...@gmail.com on 9 Sep 2011 at 4:18

Attachments:

GoogleCodeExporter commented 8 years ago 

Would it be possible to create a new diff using svn diff using the latest trunk?

Thanks for the work!

Original comment by erwin.coumans on 12 Sep 2011 at 10:04

GoogleCodeExporter commented 8 years ago 
I thought this was relative to current trunk...? O_o I show svn rev 2419.

I did make the patch using a local hg repo I'm using for the stability test 
thing (which is almost ready to share).  Just do a patch -p1 < 
fix-warnings.diff, looks like svn patches are otherwise patch -p0 *shrug*

Original comment by ejtt...@gmail.com on 13 Sep 2011 at 12:49

GoogleCodeExporter commented 8 years ago 
I see 2420 has been committed to svn, here's an updated patch.

Original comment by ejtt...@gmail.com on 13 Sep 2011 at 3:14

Attachments:

GoogleCodeExporter commented 8 years ago 
can you please submit a new patch created using svn diff (or tortoisesvn create 
patch) ?

Thanks!

Original comment by erwin.coumans on 13 Sep 2011 at 4:40

GoogleCodeExporter commented 8 years ago 
Not sure if you were still waiting on an svn-produced patch, but here's one for 
2424

Original comment by ejtt...@gmail.com on 14 Sep 2011 at 2:38

Attachments:

GoogleCodeExporter commented 8 years ago 
Noticed in a recent build i missed one in SerializeDemo, updating patch

Original comment by ejtt...@gmail.com on 14 Sep 2011 at 5:46

Attachments:

GoogleCodeExporter commented 8 years ago 
Fixed in latest trunk, thanks a lot for the patch!

http://code.google.com/p/bullet/source/detail?r=2430

Original comment by erwin.coumans on 15 Sep 2011 at 1:18