jjfreedman / bullet

Automatically exported from code.google.com/p/bullet
Other
0 stars 0 forks source link

Missing btScalars in InternalEdgeUtil and CollisionShapes #575

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
none.

What is the expected output? What do you see instead?
Use of proper btScalar typedef instead of hardcoded floats when using double 
precision mode.

What version of the product are you using? On what operating system?
2.79-rev2444

Please provide any additional information below.
There were a couple of hardcoded floats in the internaledge util, triangleinfo 
map the convex(hull)shapes.

Attached patch combines the change from float to btScalar for the above.

Note that this was only tested/used as BulletCollision lib, I did not check 
with BulletDynamics or other.

Original issue reported on code.google.com by dennis.c...@gmail.com on 8 Dec 2011 at 1:52

Attachments:

GoogleCodeExporter commented 8 years ago
thanks for the patch! I'll look into applying it for the next release

Original comment by erwin.coumans on 11 Jan 2012 at 8:31

GoogleCodeExporter commented 8 years ago
The patch has been applied in latest trunk:
http://code.google.com/p/bullet/source/detail?r=2498

Thanks for the contribution!

Original comment by erwin.coumans on 29 Feb 2012 at 3:51

GoogleCodeExporter commented 8 years ago
I had to revert the patch, those values are required to be floats for the 
serialization.

Original comment by erwin.coumans on 3 Mar 2012 at 6:24