jjgomera / iapws

python libray for IAPWS standard calculation of water and steam properties
GNU General Public License v3.0
170 stars 64 forks source link

Update _Supercooled scipy interface #49

Closed vruge closed 4 years ago

vruge commented 4 years ago

ref #48

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.06%) to 98.868% when pulling 6dc640777460beda74b97973a8fbff103bb493b1 on vruge:patch-1 into 939791c7900ac9fc0d6ca21b1094f33f5d6e64c9 on jjgomera:master.

codecov-io commented 4 years ago

Codecov Report

Merging #49 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   98.92%   98.93%           
=======================================
  Files           8        8           
  Lines        4473     4486   +13     
=======================================
+ Hits         4425     4438   +13     
  Misses         48       48           
Impacted Files Coverage Δ
iapws/_iapws.py 97.79% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 939791c...8e31092. Read the comment docs.

jjgomera commented 4 years ago

Thanks, applied!!

jjgomera commented 4 years ago

I don't like to hide import in a function, maybe I must relocate version number in setup.py or something similar.