search

jjgrainger / PostTypes

Simple WordPress custom post types.
https://posttypes.jjgrainger.co.uk/
MIT License
372 stars 48 forks source link

Internationalize the dropdown list of taxonomies #66

Closed JoaoBrlt closed 2 years ago

JoaoBrlt commented 4 years ago

Hi @jjgrainger

Firstly, thank you for this small library that really helps to simplify the code of my WordPress plugins !

The issue I'm pointing out is that the default label of the dropdown list of taxonomies is currently hard-coded with an English prefix Show all {taxonomy label}. The problem is that I mainly code websites in other languages so I need to translate it. I would suggest removing the prefix or surround it with a translation method so that we can translate it ?

Small preview of the issue : dropdown

Best regards.

jjgrainger commented 2 years ago

This was resolved in #81 where the taxonomy label is used instead of a non internationalized string