search

jjh42 / mock

Mocking library for Elixir language
MIT License
646 stars 81 forks source link

multiple mocks #48

Closed xieyunzi closed 8 years ago

xieyunzi commented 8 years ago

https://github.com/jjh42/mock/issues/44

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8cf9c158575f8c46ae5649c6fcbf8d753b872271 on xieyunzi:master into b701db2241a123f1d8a51be16eaf3c31957c0008 on jjh42:master.

xieyunzi commented 8 years ago

hello @jjh42

jjh42 commented 8 years ago

Hi. Sorry I missed this. I've added a couple of comments. Also, could you add something to the README.

Thanks,

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling b14798fc4c70cc56f46ef5e03028bc6bff8a9bea on xieyunzi:master into b701db2241a123f1d8a51be16eaf3c31957c0008 on jjh42:master.

xieyunzi commented 8 years ago

Hi @jjh42 , it's been updated.

jjh42 commented 8 years ago

Thanks @xieyunzi for updating the README. The other suggestion I had was to refactor with_mock to simply call with_mocks. Right now there is a lot of redundancy between those two macros.

jjh42 commented 8 years ago

not remove since we need backwards compatibility, refactor be implemented by calling with_mocks.

J

On Wed, Jun 29, 2016 at 11:39 AM, Reiner notifications@github.com wrote:

You mean remove with_mock ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jjh42/mock/pull/48#issuecomment-229320936, or mute the thread https://github.com/notifications/unsubscribe/AAWpXrIsO8lL5sglrPo7QEOkfoyX9yjkks5qQkt3gaJpZM4I6t7W .

xieyunzi commented 8 years ago

Haha 😅 misunderstand, updated now

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 92c47d8ed8813727383156eb78dac725a7afd1ed on xieyunzi:master into b701db2241a123f1d8a51be16eaf3c31957c0008 on jjh42:master.

jjh42 commented 8 years ago

Thanks. Great contribution. I'll try and do a new release soon.

safwank commented 8 years ago

Any update on the new release?

JGulbronson commented 8 years ago

+1 Would also like to be able to use with_mocks

safwank commented 8 years ago

Bueller?

matteosister commented 8 years ago

@jjh42 could you please tag a new release?

jjh42 commented 8 years ago

Hi. Sorry I've been swamped, will try and get to this shortly.

jjh42 commented 8 years ago

This has been published to hex now. Hopefully that resolves your problems. Please let me know how you get on.