search

jjh42 / mock

Mocking library for Elixir language
MIT License
646 stars 81 forks source link

Typo in the README.md: `assert called` and not `assert_called` #90

Closed joebew42 closed 6 years ago

joebew42 commented 6 years ago

It seems there is a typo in the readme. Basically in the examples you wrote assert_called, but the correct one should be assert called. Is it right?

Thank you :rocket:

Olshansk commented 6 years ago

Nope, it was a recent change made by @mtrudel. Please see https://github.com/jjh42/mock/pull/87

joebew42 commented 6 years ago

Oh cool! Thank you :+1:

bessey commented 6 years ago

I just ran into the same issue. While that may be the case @Olshansk, the problem is it is a recent unreleased change. Personally I think it is incorrect to have your master branch documentation be referring to an as yet unreleased version of the library, at least with no note.

Perhaps a header warning of the breaking changes, with a link to the currently released Hex docs would be appreciated for the next person that hits this issue?

Olshansk commented 6 years ago

@bessey I published v0.3.2.

For some reason the default docs page still points to v0.3.1, but the docs for v0.3.2 are available. I'm not sure if it takes time to propagate of if it's a configuration issue. I'll check back on it in a bit.