search

jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
208 stars 85 forks source link

Fix: `seperate` is not an english word. It should be `separate`. #139

Closed fernandezc closed 8 months ago

fernandezc commented 3 years ago

However, this fix, made in several comments, also affects the name of a function: seperate_interleaved.
So I marked the original as obsolete and created a new one: separate_interleaved which is intended to replace the previous one in future versions.

It is not a critical PR, so it can be ignored without any problem.

Additional changes : A deprecated decorator has been added in util/misc.

fernandezc commented 3 years ago

Hello, Do you know why it takes so long to perform the travis checks for each PR I do on the master branch of the nmrglue repository, while it is immediate on my fork? I'd like to understand! Thanks.

kaustubhmote commented 3 years ago

Nice catch! However, there are a ton of other places (in examples/doc) where things must be changed for this to be complete. So I'll not immediately merge this. I am not sure about the travis checks, but I'll try and see if this can be fixed.

fernandezc commented 3 years ago

However, there are a ton of other places (in examples/doc) where things must be changed for this to be complete.

Yes you are right. I'd noticed this also. This is why I added the deprecated decorator. But as I said before, this is not very important. Best regards.

jjhelmus commented 8 months ago

This and the other locations of seperate were replaced in #203. I think leaving the misspelled function in for backwards compatibility is fine rather than going through a deprecation cycle.