Added reading of 4D UCSFs

jjhelmus / nmrglue

A module for working with NMR data in Python

BSD 3-Clause "New" or "Revised" License

211 stars 86 forks source link

Added reading of 4D UCSFs #140

Closed krairy closed 3 years ago

krairy commented 3 years ago

Added support for 4D spectra

kaustubhmote commented 3 years ago

@krairy, this looks like a very nice addition, thanks!. However, this particular PR has way too many unrelated changes in the file, which makes reviewing a bit difficult. Can you revert back and add only the required functions (read_4d and untile_4d), and add a line in the read function that checks if the dimension is 4 and then calls the appropriate function? For any other changes, please feel free to open another PR. Let me know if I can help with this.

krairy commented 3 years ago

@kaustubhmote sure, will do! I was a bit surprised the file here does not include new functions from the latest release.