Bugfix for: Cannot import nmrglue with scipy v1.8

jjhelmus / nmrglue

A module for working with NMR data in Python

BSD 3-Clause "New" or "Revised" License

208 stars 85 forks source link

Bugfix for: Cannot import nmrglue with scipy v1.8 #167

Closed kaustubhmote closed 2 years ago

kaustubhmote commented 2 years ago

This fixes a break in nmrglue due to a reorganization of the scipy.optimize submodules in v1.8. The change is backward compatible with previous versions of scipy.

dcambie commented 2 years ago

I just came up with the same change after nmrglue stopped working in CI. A new pypi release of nmrglue including this would be great ;)

kaustubhmote commented 2 years ago

Since all previous versions of nmrglue will definitely break with the scipy >= 1.8, and since the requirements.txt in nmrglue does not pin scipy to a version lower than 1.8, it would definitely be best if @jjhelmus releases v0.9 with this change. Also see a similar request here.

dcambie commented 2 years ago

As rapid workaround it is also possible to pin scipy <1.8 in packages that depend on nmrglue, which is what I ended up doing for now