search

jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
208 stars 84 forks source link

PY3: changes not suggested by pyupgrade #179

Closed DimitriPapadopoulos closed 1 year ago

jjhelmus commented 1 year ago

LGTM

kaustubhmote commented 1 year ago

This merge may need to be partially reverted. xcpy module works within Topspin with Jython rather than CPython, which is why the antiquated style/features of Python 2.7 is used everywhere.

DimitriPapadopoulos commented 1 year ago

I just discovered that Jython only supports Python 2. Given the pace of change of Python libraries, I guess this means Jython is more or less dead. Any way, since the xcpy module works within TopSpin which includes Jython, there is no discussion here: I will revert xcpy.py and xcpy_test.py changes. Sorry about the mess.

DimitriPapadopoulos commented 1 year ago

BTW, I got confused by setup.py:

        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: 3.7',
        'Programming Language :: Python :: 3.8',
        'Programming Language :: Python :: 3.9',
DimitriPapadopoulos commented 1 year ago

Reverted in #183.