jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
211 stars 86 forks source link

Changed 'np.float' to 'float' in peakpick.py line 329 #193

Closed weisscharlesj closed 1 year ago

weisscharlesj commented 1 year ago

Changed 'np.float' to 'float' in peakpick.py line 329 to fix the np.analysis.peakpick.pick() function. NumPy deprecated the np.float function in numpy 1.20.0 which broke the ng.analysis.peakpick.pick() function giving an error (see nmrglue issue #192). Changing 'np.float' to 'float' is the recommended fix by NumPy as it "will not modify any behavior and is safe." Using the float() function instead of np.float() looks to be consistent with the rest of the code in peakpick.py.