jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
211 stars 86 forks source link

Added a function for manual phase correction in the module proc_autophase #36

Closed kaustubhmote closed 9 years ago

kaustubhmote commented 9 years ago

This will require matplotlib with an interactive backend

Will prevent a frequent back-and-forth between pipe/bruker for data processing This is in response to my own requirements as well as this discussion: https://groups.google.com/forum/#!topic/nmrglue-discuss/tYzYFFIDxN0

kaustubhmote commented 9 years ago

The tests seem have failed due matplotlib not being a requirement for building nmrglue Will it be possible to either add this a requirement or alternatively, include the manual phase correction function as an optional processing module?

jjhelmus commented 9 years ago

@kaustubhmote Thanks for the contribution.

If you move the import statements to inside the manual_ps function then the tests should pass as is. This would also be preferred as then matplotlib is an optional dependency which users will not be required to install if they do not wish to use this functionality.

You will need aslo need to modify the docstring of the function to use the [NumPy docstring]*https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt) headings and format. This will allows the function to be included in the nmrglue documentation.

jjhelmus commented 9 years ago

Created a pull request against this branch to clean up the function a bit and complete the documentation. This is really a great feature @kaustubhmote. Once you merge this into your branch this should be good to go.