ENH: reference processed Bruker strip transformed data

jjhelmus / nmrglue

A module for working with NMR data in Python

BSD 3-Clause "New" or "Revised" License

211 stars 86 forks source link

ENH: reference processed Bruker strip transformed data #50

Closed kfritzsc closed 8 years ago

kfritzsc commented 8 years ago

For consideration: a fix for issue #49; when Bruker parameters STSI and/or STSR are set, the spectrum read by bruker.read_pdata is incorrectly referenced.

An optional bool parameter was added to bruker.guess_udic called strip_fake. If set to True and if the dic has the parameters STSI or STSR the sweep width and carrier frequency is faked so that unit_conversion objects can be used like normal.

coveralls commented 8 years ago

Changes Unknown when pulling c1a5f980aaa1cafac01d47f4ac0f9b6ce30bf048 on kfritzsc:bruker-pdata-ssti-sstr into \ on jjhelmus:master**.

jjhelmus commented 8 years ago

This looks good to me. Any chance you could provide the data used in the example so that others can run it? Either way I'm happy with this change, merging. Thanks for the fix.

kfritzsc commented 8 years ago

I will find some data for this example and post a link here. Please allow me some time to find a dataset I can share.

jjhelmus commented 8 years ago

No problem. Even data from some reference or test sample is fine. I think I have some of that already in nmrglue.