search

jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
211 stars 86 forks source link

Manual phase correction in Jupyter notebooks #65

Closed kaustubhmote closed 7 years ago

kaustubhmote commented 7 years ago

Added and optional flag to the manual phase correction function to allow for easy manual phase correction in Jupyter notebooks (without changing to IPython or the Python Interpreter). The default is the same as before, but in Jupyter Notebook, you can now use the 'notebook=True' option.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 20.658% when pulling be84367226c779ca0322af6adc1ae1ccfe37cc19 on kaustubhmote:master into 52922831fa20d9510277ef14b30005736d9cb8ee on jjhelmus:master.

kaustubhmote commented 7 years ago

This small a change in coverage should not fail the build, right? In either case, I am not sure how to add a unit test for a interactive plotting function specifically for Jupyter notebooks. Any suggestions?

jjhelmus commented 7 years ago

@kaustubhmote Do not worry about the coverage test. I set up that service some time ago but it is not helping in this case. I want to try out this change locally before merging, should be able to later today.

jjhelmus commented 7 years ago

Thanks @kaustubhmote for the submission. This is a really exciting addition, being able to phase spectra in the notebook is neat!