search

jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
212 stars 88 forks source link

Code to read in Tecmag TNMR .tnt files #9

Closed chatcannon closed 11 years ago

chatcannon commented 11 years ago

I've copied (with a few modifications) some code from my pytnt repository to read in Tecmag .tnt data files

I'm not entirely sure what is needed for the API so please point out any deficiencies.

jjhelmus commented 11 years ago

@chatcannon Chris, this looks like some great work that I would love to include in nmrglue, thanks for making this possible. Would it be possible for you to send me the .tnt files used in the tests so that I could run them myself and include them in the test_data zip file? Once I have them I'll take a look at the code in more detail and see if these is anything that needs to be cleaned up. Feel free to email them to me (jjhelmus@gmail.com) or post them somewhere and I'll download them.

chatcannon commented 11 years ago

Did you get the e-mail?

jjhelmus commented 11 years ago

Yup I got the email, the code looks great. There are a few minor PEP8 issues and I'll want to add the new module to documentation. Do you want me to do those after merging or do you to clean up the code and add the lines to the documentation scripts?

Also it is alright is I include the two test files to the test_data zip file?

jjhelmus commented 11 years ago

BTW, from the looks of the pytnt code it looks like Tecmag is doing their transform in the same manner as nmrglue's fft_norm function.

chatcannon commented 11 years ago

Yes, please add the test files to the zip. If you let me know what else needs doing re: documentation etc then I can do it

jjhelmus commented 11 years ago

Merged, I made a few minor style changes and added the module to the docs in commit d812b5db9d.

jjhelmus commented 11 years ago

Thanks for the code @chatcannon !