search

jjk-jacky / statusnotifier

Library to use KDE's StatusNotifierItem via GObject
Other
25 stars 8 forks source link

Fix gtk-doc build with libtool #15

Closed akien-mga closed 7 years ago

akien-mga commented 7 years ago

LT_INIT should be introduced before GTK_DOC_CHECK in configure.ac to make gtk-doc build to use libtool.

This also fixes the gtk-doc build with --disable-static.

Patch by @wally-mageia, tested with http://svnweb.mageia.org/packages?view=revision&revision=1092470

akien-mga commented 7 years ago

For the reference, here's the kind of build issue that happens with --enable-gtk-doc and Mageia's custom ldflags [0] without this patch: https://hastebin.com/agucinuluf.sql

[0] LDFLAGS=' -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id -Wl,--enable-new-dtags'

jjk-jacky commented 7 years ago

Oh yeah, good catch. (Man that GTK_DOC_CHECK block was really out of place, don't know what happened there...)

Applied, thanks a lot!

akien-mga commented 7 years ago

Ah, I'll remember to make PRs against the next branch next time :)

jjk-jacky commented 7 years ago

Ah, I'll remember to make PRs against the next branch next time :)

Ah yeah, I always commit to next :) (But I also like fast-forwards, no merge commit, and I think github doesn't always see that either...)

PS: Just in case, you know that html documentation is included in the tarball, right? So you don't need to use --enable-gtk-doc or have gtk-doc to build; Not that I mind (obviously) :)