jjlee / mechanize

Stateful programmatic web browsing in Python, after Andy Lester's Perl module WWW::Mechanize .
http://wwwsearch.sourceforge.net/mechanize/
618 stars 123 forks source link

Refactor functional_tests to work with twisted.web instead #56

Closed kovidgoyal closed 7 years ago

kovidgoyal commented 12 years ago

The tests used to use twisted.web2 which has been discontinued. Refactored to use twisted.web from modern twisted. All tests pass.

jjlee commented 12 years ago

Thanks for this!

Have been very busy with a new job, but I'll try and make time look this weekend.

John

On Tue, 7 Feb 2012, Kovid Goyal wrote:

The tests used to use twisted.web2 which has been discontinued. Refactored to use twisted.web from modern twisted. All tests pass.

You can merge this Pull Request by running:

git pull https://github.com/kovidgoyal/mechanize master

Or you can view, comment on it, or merge it online at:

https://github.com/jjlee/mechanize/pull/56

-- Commit Summary --

  • Tell git to ignore compiled python files
  • Refactor the functional tests to use twisted.web as twisted.web2 has been discontinued

-- File Changes --

M .gitignore (1) M ChangeLog (2) M release.py (4) M test-tools/testprogram.py (8) M test-tools/twisted-localserver.py (126) M test/test_functional.py (11)

-- Patch Links --

https://github.com/jjlee/mechanize/pull/56.patch https://github.com/jjlee/mechanize/pull/56.diff


Reply to this email directly or view it on GitHub: https://github.com/jjlee/mechanize/pull/56

jamesbroadhead commented 7 years ago

Thank you for your contribution to mechanize!

Following the process in #117, future work on mechanize will be occurring here: https://github.com/python-mechanize/mechanize.

Please re-file your PR there (where it will get attention, and hopefully merged)