Feature/move empty row filtering

jjm3x3 commented 4 months ago

Summary/Acceptance Criteria

Since actually building contestant data will be more difficult for BB and require more of the "partialContestants" to be exposed we are going to remove that from the wikiFetch and instead into the wikiQuery.

Screenshots

N/A

Confirm

[x] This PR has unit tests scenarios.
[X] This PR is correctly linked to the relevant issue or milestone.
[X] This PR has been locally QA'd.

/assign me

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
amazing-race-fantasy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 8, 2024 2:42am

jjm3x3 commented 4 months ago

This certainly works, and I'll try to take another look at it tomorrow. isPartialContestantData feels a bit clumsy, but that might be due to the nature of working with Wikipedia data for contestant data across different shows without managing our own DB 😅 So this might be as good as it gets.

I can go ahead and approve, since any improvements here would likely be expanding upon this 👍

First off, thanks for taking a look at it and vetting the logic for me so quickly. I totally agree that isPartialContestantData feels a bit clumsy. My first response to that would be to ask "is it worse than what we had with filterEmptyContestants which technically wasn't really doing that? And to the second part

that might be due to the nature of working with Wikipedia data for contestant data across different shows without managing our own DB

Yeah, that is kind of how it feels. I am certainly open to better ways of doing this! Especially since, as you will see in #124 , I started to make even more changes that make the logic in this function even worse to read 😬

jjm3x3 / AmazingRaceFantasy