123 create scoring page

jjm3x3 commented 4 months ago

Summary/Acceptance Criteria

This change makes the necessary changes to the scoring page and mechanism support a BigBrother league. Main changes include

Injecting competingEntity "parser" (formerly getTeamList for Amazing race)
Updates the getNumberOfRounds to omit Number.MAX_VALUE and a test for it
Update getKey to support BB showContestant names
Update getFriendlyName to just show BB showContestants full name

Screenshots

N/A since this doesn't change any visible behavior.

Confirm

[x] This PR has unit tests scenarios.
[x] This PR is correctly linked to the relevant issue or milestone.
[x] This PR has been locally QA'd.

/assign me

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
amazing-race-fantasy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 14, 2024 5:31pm

jjm3x3 commented 4 months ago

I am glad to have extracted getNumberOfRounds into a separate testable function, but that same code is also in contestantRoundScoreGenerator and we should probably only have it one place.

jjm3x3 / AmazingRaceFantasy