Open jjm3x3 opened 1 month ago
So this issue is also causing one of our tests introduced in #127 to log a warning so fixing this will be nice for that!
I also did write a test to demonstrate the whole issue, it is committed in the corresponding branch!
When going through the original effort of coming up with the necessary parsing logic for a Big Brother league one thing that was encountered was the issue where how a Wikipedia table renders when two rows share a merged cell. In the HTML that underlies that table only one of those rows will actually have the column (cell). As a result of that "Double-Evictions" are pretty deadly to the parsing logic. In order to get through that I had made an assumption that is some one did not have a status of winner and didn't have a calculated (parsed out) exit day, all of which coinsides with that same show contestant not having any status at all in the table then we could just assume that they were the result of a double eviction and calculate their elimination order accordingly. Unfortunately this assumption proved faulty when the new season started and it showed up that show contestants who have not been evicted and who are still playing will also have no status. Since we don't yet have a double eviction this season I was able to make a quick hacky change, (and even recognized at the time that it would probably bite us with this comment) but that didn't stop us from shipping it, especially because we decided to punt on some of the tests and so it was not caught in a regression like it should have been. This will most likely break by the time we have double eviction. And so the fix here is to figure out how we can address this while making sure it continue to work for contestants who are still actively competing in the house.