jjmccollum / teiphy

A Python package for converting TEI XML collations to NEXUS, BEAST 2.7 XML, and other formats
MIT License
11 stars 3 forks source link

add tip date sampling for beast #69

Closed rbturnbull closed 1 year ago

rbturnbull commented 1 year ago

See:

rbturnbull commented 1 year ago

Hi @jjmccollum - this is now in the tipdates branch. It is running on my machine and in the CI. The date values seem to be changing in the log and are showing up in densitree.

jjmccollum commented 1 year ago

@rbturnbull Excellent! This will be a great feature to have in place for conversions from TEI to BEAST XML. If you have all the changes in place in that branch, feel free to make a pull request and I'll give it a look.

rbturnbull commented 1 year ago

Hi @jjmccollum - because it branched from the beast xml branch, it might be best to just merge it back to the beast branch and continue from there and then it can be merged with main through a PR when that is ready. If you're happy with that, should I merge it with the beast xml branch?

jjmccollum commented 1 year ago

@rbturnbull Oh, right. Yeah, a simple merge would be better in that case. Thanks for asking!

rbturnbull commented 1 year ago

I've merged tipdates into beast-xml. @jjmccollum you should be able to switch the templates to jinja now if you like