search

jjmschofield / github-codeowners

29 stars 16 forks source link

fix: only count lines if required by output plugin #44

Closed FauxFaux closed 3 years ago

FauxFaux commented 3 years ago

Avoid reading every file every time, which has some performance overhead, but not actually all that much vs. other egregious problems.

There's not really a good way to phrase this, either the command has to be aware of the output mode, the cli has to be aware of the owned file, or the output code has to be async and do the work there. I picked the first.

jjmschofield commented 3 years ago

Will grab the tooling fixes here in another branch, https://github.com/jjmschofield/github-codeowners/pull/49 should have solved this (with a big old rethink and refactor).

other egregious problems

any clues?