search

jjneely / buckytools

Go implementation of useful tools for dealing with Graphite's Whisper DBs and Carbon hashing
Other
87 stars 21 forks source link

buckytools unbuildable in golang:latest (1.14.6) and golang:1.13 container #35

Closed jdblack closed 4 years ago

jdblack commented 4 years ago

Attempting to build buckytools on the latest golang container, as per the current build instructions in the readme, apparently fails:

~/code/bucky$ mkdir output;   docker run   -v output:/output -ti golang:latest  /bin/bash
root@685f3a119d43:/go# go get github.com/jjneely/buckytools
root@685f3a119d43:/go# cd $GOPATH/src/github.com/jjneely/buckytools
root@685f3a119d43:/go/src/github.com/jjneely/buckytools# go install ./...
cmd/bucky/tar.go:16:8: code in directory /go/src/github.com/jjneely/buckytools/vendor/github.com/golang/crypto/ssh/terminal expects import "golang.org/x/crypto/ssh/terminal"
root@685f3a119d43:/go/src/github.com/jjneely/buckytools#
jjneely commented 4 years ago

Hi,

I pushed a change to master that I think will address this issue for the time being until the code is ported to use Go modules. Let me know if that works for you.

jdblack commented 4 years ago

Worked great! Thank you!