jjohnsnaill / SubworldLibrary

Dimensions in Terraria, made easy.
44 stars 24 forks source link

Subworld processes do not inherit commandline arguments #40

Closed CreepyCre closed 4 months ago

CreepyCre commented 5 months ago

Subworld processes do not inherit commandline arguments. Relevant arguments may include:

Passing -modpath and -modpack is critical for the subserver to actually load mods correctly.

jjohnsnaill commented 5 months ago

Will fix -modpath, -modpack, -secure and -forcepriority not being inherited in 2.2.2.2! -port and -ip don't need inheriting since subservers don't use them, and -difficulty should be synced separately. I'll have to take a closer look at -config in case there's something subservers shouldn't inherit.

rehashedsalt commented 4 months ago

The Terraria Wiki has what looks to be an exhaustive list of all configs for vanilla, and tML maintains a list on their GitHub Wiki. One more thing that jumps out as potentially relevant is steamworkshopfolder.

jjohnsnaill commented 4 months ago

Will make subservers inherit -steamworkshopfolder as well, thanks for letting me know! The world and seed config options seem a little dangerous to subworlds, but configs load before SubLib so they should get overridden. Adding -config to the list.