search

jjones-99 / cs4500-sp2020-a1-part2-jones-tam

Jackie Tam and Jared Jones' work for Assignment 1: Part 2 of Software Development in Spring 2020.
0 stars 2 forks source link

Remove get() from string class #17

Closed tomharmon closed 4 years ago

tomharmon commented 4 years ago

Could you please remove the get() method from string? I can't find any issues where someone requested it, and get() is not in the standard spec on chasebish's repo, so the addition of get() re-introduces the whole dependency graph of object/string.

jjones-99 commented 4 years ago

Fixed in a7e4757. Sorry about that. It doesn't really make sense to have a String but no way of getting the String value, but I guess that's out of scope for this assignment.

tomharmon commented 4 years ago

thank you! yes i agree about getting the string value, but all of CwC doesn't make much sense anyways so 😅