jjsheets / nebula

a game engine project
GNU Lesser General Public License v2.1
0 stars 0 forks source link

Code Coverage adjustments #94

Closed jjsheets closed 2 years ago

jjsheets commented 2 years ago

Description

Failure paths are not important to test. The code in them is using code that already is known to work via other code paths and with known good throw statements. Obsessive obedience to a code coverage target is unnecessary. Rather, testing should cover as much of the standard operation of the code as is possible.

This PR should adjust the codecov settings to permit a decrease of up to 1% in coverage for a successful status check in PRs, and a decrese in the upper limit of desired coverage (70-100% to 70-90%). It also does some minor adjustments to the Vulkan mocking; fixing incorrect text replacements from a previous commit, and removing unneeded logging commands.

Checklist

github-actions[bot] commented 2 years ago