search

jjshoe / slackbot-pr-reminder

Slackbot which reminds channels about PR's waiting on repo's
GNU Affero General Public License v3.0
2 stars 2 forks source link

Bot messages result in push notifications #2

Open ghost opened 8 years ago

ghost commented 8 years ago

First off, great idea and execution behind the reminder!

Currently, the bot messages use @channel, which results in a push notification for all channel members. That level of notification is the highest available in Slack, so either no mention or @here may be more appropriate for a daily reminder.

Since @channel sends push notifications to all members of a channel, it adds noise to the messages for a channel and could reduce the likelihood that someone who is not currently active in Slack would read an urgent message sent with @channel.

Here's the Slack documentation for announcements: https://get.slack.help/hc/en-us/articles/202009646-Making-announcements

jjshoe commented 8 years ago

This is as designed, the entire intention of the bot is to annoy people into finally doing something about open PRs. If people don't want to get @channel'd, they simply need to make sure they monitor and review PRs in a timely manner.

I'll leave this issue open if others want to discuss, but any change to this defeats the entire purpose of this bot.

ghost commented 8 years ago

You're interpreting this issue as causing annoyance instead of potentially causing harm by having legitimate emergency messages sent with @channel ignored because of the huge increase in @channel messages sent by this bot.

As important as having open PRs getting reviewed is, it is not as important as messages like "@channel: We're suddenly serving a ton of 500s in prod".

jjshoe commented 8 years ago

I would def. take a PR making messages configurable, though I wouldn't personally make the choice to set that value to anything else in the place where we run and experience this bot together.