jjsullivan5196 / wvkbd

On-screen keyboard for wlroots
GNU General Public License v3.0
280 stars 55 forks source link

Theme gets messed up if the keyboard is opened and closed many times #59

Closed rdbo closed 7 months ago

rdbo commented 10 months ago

wvkbd version: wvkbd-0.14.3 Compositor: river 0.2.6

After opening and closing the keyboard a couple of times, the theme gets messed up. It is supposed to look like this at all times: image

Instead, it will look like this after opening and closing (pkill -9) a couple of times: image

I'm not sure what exactly this couple be, but it is very odd. The command I am using to toggle the keyboard is:

if pidof wvkbd-mobintl; then
    pkill -9 wvkbd-mobintl
else
    wvkbd-mobintl -L 280 --fn "FiraCode Nerd Font Mono:style=Bold" --bg "1b1b1b" --text "e6e6b5" --text-sp "e6e6b5"
fi
proycon commented 8 months ago

That is odd behaviour indeed, I have never seen this on any other compositor (Hyprland, sway, wayfire). I also tried river now (0.2.6) with latest git wvkbd and there too I can't reproduce it. A wild guess is that perhaps the latest patches that fixed redrawing fixes this too.

rdbo commented 7 months ago

I managed to record a video of me doing this in QEMU with river built on master branch, with wvkbd on v0.14.4 It is kind of annoying to reproduce, but happens once in a while

https://www.youtube.com/watch?v=n_8VfVSNlic&t=65s

This is the command that runs once I press the keyboard button on the status bar:

#!/bin/sh

notify-send "󰌌 Toggled virtual keyboard"
if pidof wvkbd-mobintl; then
    pkill -9 wvkbd-mobintl
else
    wvkbd-mobintl -L 280 --fn "FiraCode Nerd Font:style=Bold" --bg "132a33" --fg "101a20" --fg-sp "101a20" --text "00ffc8" --text-sp "00ffc8"
fi

I also noticed that you don't have to open/close it really fast for this to happen, I got it to happen once right after I booted the OS on QEMU, on the first try. But it's easier to reproduce by toggling fast like this.

proycon commented 7 months ago

Spooky, especially that is sometimes reproduces and sometimes not. I have never experienced this behaviour yet, but I also never tried River. I would be more inclined to suspect a bug in River (since I havent't seen it on either sway, Hyprland or Wayfire), but I'm just guessing here.

Let's keep this open and see if anybody else experiences the same issue (either on River or another compositor).