search

jjtParadox / Barometer

An old experimental test library for 1.12 MinecraftForge mods.
GNU Lesser General Public License v3.0
7 stars 3 forks source link

A couple of conveniences for CI pipelines #4

Closed tdaffin closed 6 years ago

tdaffin commented 6 years ago

In order to make this work 'out of the box' in a CI pipeline I think it is work adding calls to create the working directory and populate it with an already agreed to eula. I've also been able to successfully populate a server.properties file in a similar fashion, but I figured that I'd submit something simpler first. If you think this is a good idea I can submit a PR to update the README.md with these changes too.

jjtParadox commented 6 years ago

Thanks for the PR! This looks good.

I think updating the README would be a good idea, and it would probably be prudent to include a statement like "By using this you are agreeing to the Minecraft EULA" since we auto-set the EULA agreement to true. I'll leave this PR open if you want to include the README changes with it.

If you're working on auto-populating a server.properties file, I discussed some good default settings in this issue that you might find useful.

I won't be porting this to the 1.10 branch as that branch is mostly archived, but I wouldn't object to a PR being submitted for that branch too.

Let me know if I should merge this in right away or if you want to include the README changes.

tdaffin commented 6 years ago

I've pushed the README changes, including a link to the actual Mojang EULA to make things really clear.