search

jjtobin / auto_selfcal

MIT License
17 stars 8 forks source link

Fix problems that occur when cont.dat happens to be missing some targets #22

Closed psheehan closed 1 year ago

psheehan commented 1 year ago

This is to fix the variety of issues that can occur when cont.dat is missing some of the targets, typically due to mitigation during the pipeline run.

As a side effect, this also brings the updates made to use the new uvcontsub that were done originally in my fork but are also valid in jjtobin/auto_selfcal main.

I have not yet tested these updates on this branch specifically, only on the companion fix_contdotdat_matching_bug branch on my fork. I'm going to try to set such a test running this weekend and can confirm that all worked as expected once that is done, hopefully by the end of the weekend.

psheehan commented 1 year ago

By the way, @jjtobin - if you wanted to try out git cherry-pick to pull in the uvcontsub updates separately, feel free to do that before merging - all should still work just fine. Because some changes I made touched that, I needed to pull in here, but I didn't want to prevent you from trying that out, either!

psheehan commented 1 year ago

Ok, checked this over and all appears to be working correctly now. I made one small update this morning, which is to make the "WARNING" show up in red text to make it more noticeable.

Another small update - I noticed some small issues with the logic in whether to use uvcontsub or uvcontsub_old that are now fixed in this pull request.

I'm happy to have this merged unless you have any further changes that need to be made.

psheehan commented 1 year ago

Ok, fixed one last issue where the target name wasn't being displayed properly in the weblog. Now should really be ready to merge.