search

jjuback / gc-excelviewer

Visual Studio Code extension for viewing Excel spreadsheets and CSV files.
Other
216 stars 39 forks source link

Editing and Saving CSV in CSV Editor Removes Some Newly Added Data #201

Open theparadox1083 opened 2 years ago

theparadox1083 commented 2 years ago

I have confirmed this on three separate computers running Visual Studio Code. Two in a domain environment and a third personal computer that has never interacted with a domain and has zero group policies impacting it at all. At this point, I feel it must be a bug as it occurs consistently on all three machines.

Excel Viewer v4.2.54 VSC Version: 1.67.2 (user setup) Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5 Date: 2022-05-17T18:15:52.058Z Electron: 17.4.1 Chromium: 98.0.4758.141 Node.js: 16.13.0 V8: 9.8.177.13-electron.0 OS: Windows_NT x64 10.0.19044

With a CSV in the "CSV Editor" that is part of Excel Viewer, I added several rows of data and then saved. Much of the new data disappears from the table and is also not saved. Below is a simple example with a small example CSV.

Here is the original data, stored in a CSV and viewed in the default text editor: Original Text

The CSV is reopened via the "CSV Editor": Reopen Editor With

Four more rows are added to the data: Table New Data

Most of the new data disappears upon saving (CTRL+S) or via the File menu: Table After Save

The loss of data is also reflected in the file, viewed via the default text editor: Text After Save

Thank you.

jjuback commented 2 years ago

It appears that values that are pasted into a cell are being ignored, but typed values are OK. Working on a fix now.

jjuback commented 2 years ago

@theparadox1083 Version 4.2.55 is now available and fixes these issues. In addition to pasted text being ignored, there were problems when editing the final cell in a row.

mysq1isworst commented 1 year ago

I think the problem didn't get fixed. I'm using Version 4.2.56 now, when I pasted a whole line of data into my chart and save. It can only keep very little part of my change.(One or two strings) All of others go back to the way before I modify charts. Pls check this.

jjuback commented 1 year ago

@mysq1isworst I have a couple questions that would help to pin this down:

  1. Does the destination row in the CSV contain any multiline cells?
  2. Did the pasted row come from the open editor, or from another app?