Querypluginsupdates - Githubissues

jjw24 / Wox

Launcher for Windows, an alternative to Alfred and Launchy.

http://wox.one

MIT License

154 stars 12 forks source link

Querypluginsupdates #104

Closed theClueless closed 4 years ago

theClueless commented 4 years ago

This has some changes that I think could be really good for perf.

add 100 ms delay to binding of query text to remove some unneccery plugin queries.
some changes to how the cancellation token is moved and cached in the method
a cancellation in the parallel foreach loop that will stop it when the next query is starting when the older one didn't finish.

having said that I haven't done enough manual testing on this and if you could do some it could really help

jjw24 commented 4 years ago

I have created a test release for this https://github.com/jjw24/Wox/releases/tag/PR104%2Bv1.3.524%2BJJW24.v1.35.16, perhaps we @SysC0mp, and anyone else interested can test it out during this period and provide our observations here.

jjw24 commented 4 years ago

Initial testing from playing around and using the wildcard searches seems very promising, alot faster than before espcially going through my dropbox files from the top level folder.

I have had run into one of two queries so far where the icons dropped off after scrolling down. Let me see if i can replicate consistently.

jjw24 commented 4 years ago

Doing some testing directly from using Wox on the folder plugin, thought I share the results:

theClueless commented 4 years ago

@jjw24 the change should not improve the time for a specific plugin, it will cancel faster older queries, for example when I want to type the query: "c:\temp\something\something\something" in today depend on how fast I write it might more than just the full query but also the parts before: "c:\te" -> "c:\temp\som" -> "c:\temp\somethi" -> etc... and my changes will make wox cancel the old queries faster and because of the binding delay it will start a little later and will aggregate changes faster. so the overall experience should be better, but for example if you just paste a full query into wox it should the same as today,

theClueless commented 4 years ago

@jjw24 can we merge this ?

jjw24 commented 4 years ago

@jjw24 can we merge this ?

Sorry bud been busy with some other commitments recently, love to merge soon but haven't had the chance to finish looking at the rest of the changes in this PR. Let me get back to you