search

jjw24 / Wox

Launcher for Windows, an alternative to Alfred and Launchy.
http://wox.one
MIT License
154 stars 12 forks source link

.NET Core Upgrade #155

Closed bkudiess closed 4 years ago

bkudiess commented 4 years ago

This PR contains the upgrade from .NET framework to .NET Core.

It includes updates to deprecated libraries to new ones as well as some small code changes needed for the upgrade.

Upgrades all plugins, core wox code and test projects

Manually validated all plugins and run existing tests.

jjw24 commented 4 years ago

Hey how's it going. Thanks for the big lift to get Wox to .Net Core. Let me know when PR is in ready stage via selecting reviewer.

bkudiess commented 4 years ago

Hey @jjw24, no problem. PR is ready for review :), but I don't think I have permissions to select a reviewer. And your build seems to failing due to missing dependencies from .net core, it needs to be upgraded as well.

ryanbodrug-microsoft commented 4 years ago

This PR contains the upgrade from .NET framework to .NET Core.

It includes updates to deprecated libraries to new ones as well as some small code changes needed for the upgrade.

Upgrades all plugins, core wox code and test projects

@bkudiess Can you please include, what steps you took to test and validate this change?

bkudiess commented 4 years ago

@ryanbodrug-microsoft, updated PR description.

theClueless commented 4 years ago

@bkudiess thanks for your work :)

please update the azure-pipelines.yml to update the build and verify it is working as expected. in order to build .net core 3.1 you need to add a build step for the sdk - steps:

https://stackoverflow.com/questions/59241957/net-core-3-1-not-yet-supported-in-azure-pipelines-hosted-agents-getting-netsdk

bkudiess commented 4 years ago

@theClueless updated the pipeline for .net core, but it still seems to be failing. Could you take a look and see if you can figure out why?

jjw24 commented 4 years ago

@bkudiess I can take a look at the build logs later in the day if @theClueless hasn't got back to you.

@bkudiess installing and running a couple community built plugins have been tested?

jjw24 commented 4 years ago

Actually initial quick glance looks like it's the UWP(Programs plugin) project depedency on that specific Win SDK, might need to switch back to the old win image? @theClueless

jjw24 commented 4 years ago

In the short time I was playing with the pipeline I removed UWPDesktop reference in Program plugin and added an absolute path to Win 10 SDK version 18362 which is included in the windows-2019 image.

This gets a successful build in Pipelines and contributors can also install the SDK 18362 via VS2019 locally as well. However I have not tested the new build and wonder if this the best way forward.

alekhyareddy28 commented 4 years ago

Regarding the libraries such as ppy.squirrel.windows, Splat, Pinyin4DotNet and DeltaCompressionDotNet which are restored using .NET Framework versions, we need to make sure that we are not breaking anything.

The ppy.squirrel.windows package supports packaging apps developed using .NET Core but it hasn't PR'd it yet because the developer says it's a bit hacky. However, we could use the Squirrel.Windows package itself and package Wox as a non C# Application using Update.exe as is mentioned in this issue.

Any thoughts on the same?

jjw24 commented 4 years ago

In the short time I was playing with the pipeline I removed UWPDesktop reference in Program plugin and added an absolute path to Win 10 SDK version 18362 which is included in the windows-2019 image.

This gets a successful build in Pipelines and contributors can also install the SDK 18362 via VS2019 locally as well. However I have not tested the new build and wonder if this the best way forward.

Disregard above.

Hi @bkudiess in your PR please remove UwpDesktop reference in Plugin.Program project and add Microsoft.Windows.SDK.Contracts version 10.0.18362.2005. This should get the build and UWP code successfully working. Tested Wox after the change, able to successfully start up, run and load UWP apps.

Will also PR dev branch with the changes and up .Net Framework to 4.6.2 for the time being.

jjw24 commented 4 years ago

Hi @bkudiess, I have made additional changes including to bring this PR inline with the latest changes in master, could you see if you can merge this in? https://github.com/bkudiess/Wox/pull/1