search

jjw24 / Wox

Launcher for Windows, an alternative to Alfred and Launchy.
http://wox.one
MIT License
154 stars 12 forks source link

Icon flickering when searching #171

Closed jjw24 closed 4 years ago

jjw24 commented 4 years ago

Icons flickering due to results constantly being updated for query result text highlighting.

How to reproduce: Search 'settings' letter by letter, focus on Wox's Settings query result and you will notice the icon flickers despite the result not changing.

This issue does not exist prior to query result text highlighting feature.

Possible root cause: The compare result method will return true most of the time as highlight data for both title and subtitle changes. This will mean same results always get updated in ResultsViewModel as user types, thus the flickering as same icons get reloaded constantly. image

@SysC0mp any thoughts on how we can resolve this?

jjw24 commented 4 years ago

closing and will be addressed in Flow