search

jjw24 / Wox

Launcher for Windows, an alternative to Alfred and Launchy.
http://wox.one
MIT License
154 stars 12 forks source link

Added Turkish translation and some other i18n work. #52

Closed ismailcarlik closed 5 years ago

jjw24 commented 5 years ago

Hey thanks for the PR, I will take a look later. One thing I noticed though is UWPDesktop nuget package is removed, what's the idea behind that？

ismailcarlik commented 5 years ago

Hey thanks for the PR, I will take a look later. One thing I noticed though is UWPDesktop nuget package is removed, what's the idea behind that？

oh, I forgot adding it back before commit. I am using Windows SDK 17763 and it doesn't require -also fails at build phase- UWPDesktop package.

jjw24 commented 5 years ago

Hey this is a really nice PR, thank you for your work on the Turkish translation and tidying up the English versions, really like how you separated the keys to dialog and standard sys display.

I would love to merge and release this if you could update the PR with the above comments.

ismailcarlik commented 5 years ago

I accidentally removed my fork while trying to remove my wox/Wox repo. So I can't make any changes now.

I suppose you should close this PR without merging and later i'll do the changes again with the points you subjected above.