marker_image_list language

[horus68]

In your module jjwg_Markers https://github.com/jjwdesign/JJWDesign-Google-Maps/tree/master/SugarModules/modules/jjwg_Markers

I found a 'marker_image' array with a list 'options' => 'marker_image_list',

The list is in the CRM main language file \include\language\en_us.lang.php

$app_list_strings['marker_image_list']['days_dim'] = 'Days Dim';
$app_list_strings['marker_image_list']['days_dom'] = 'Days Dom';
$app_list_strings['marker_image_list']['days_jeu'] = 'Days Jeu';
$app_list_strings['marker_image_list']['days_jue'] = 'Days Jue';
$app_list_strings['marker_image_list']['days_lun'] = 'Days Lun';
$app_list_strings['marker_image_list']['days_mar'] = 'Days Mar';
$app_list_strings['marker_image_list']['days_mer'] = 'Days Mer';
$app_list_strings['marker_image_list']['days_mie'] = 'Days Mie';
$app_list_strings['marker_image_list']['days_qua'] = 'Days Qua';
$app_list_strings['marker_image_list']['days_qui'] = 'Days Qui';
$app_list_strings['marker_image_list']['days_sab'] = 'Days Sab';
$app_list_strings['marker_image_list']['days_sam'] = 'Days Sam';
$app_list_strings['marker_image_list']['days_seg'] = 'Days Seg';
$app_list_strings['marker_image_list']['days_sex'] = 'Days Sex';
$app_list_strings['marker_image_list']['days_ter'] = 'Days Ter';
$app_list_strings['marker_image_list']['days_ven'] = 'Days Ven';
$app_list_strings['marker_image_list']['days_vie'] = 'Days Vie';

It looks like a translated list already, as in "Jeu, Mar, Mer" for french and "Qua, Qui, Sex, Sab" for Portuguese. But the word "Days" is not translated in any string. So should this be translated in full? This is quite strange to be localized!

Why not make a single list part of the module main language file so its easier to be translated on all languages? https://github.com/jjwdesign/JJWDesign-Google-Maps/blob/master/SugarModules/modules/jjwg_Markers/language/en_us.lang.php

[horus68]

ordering the list we can see that there are translations for 3 languages. How can we translate to any other language? The list should have only english keys and values so we could translate to any other language (only the values will change, as normally)

Portuguese
1 $app_list_strings['marker_image_list']['days_dom'] = 'Days Dom';
2 $app_list_strings['marker_image_list']['days_seg'] = 'Days Seg';
3 $app_list_strings['marker_image_list']['days_ter'] = 'Days Ter';
4 $app_list_strings['marker_image_list']['days_qua'] = 'Days Qua';
5 $app_list_strings['marker_image_list']['days_qui'] = 'Days Qui';
6 $app_list_strings['marker_image_list']['days_sex'] = 'Days Sex';
7 $app_list_strings['marker_image_list']['days_sab'] = 'Days Sab';

French
1 $app_list_strings['marker_image_list']['days_dim'] = 'Days Dim';
2 $app_list_strings['marker_image_list']['days_lun'] = 'Days Lun';
3 $app_list_strings['marker_image_list']['days_mar'] = 'Days Mar';
4 $app_list_strings['marker_image_list']['days_mer'] = 'Days Mer';
5 $app_list_strings['marker_image_list']['days_jeu'] = 'Days Jeu';
6 $app_list_strings['marker_image_list']['days_ven'] = 'Days Ven';
7 $app_list_strings['marker_image_list']['days_sam'] = 'Days Sam';

Spanish
1 $app_list_strings['marker_image_list']['days_dom'] = 'Days Dom';
2 $app_list_strings['marker_image_list']['days_lun'] = 'Days Lun';
3 $app_list_strings['marker_image_list']['days_mar'] = 'Days Mar';
4 $app_list_strings['marker_image_list']['days_mie'] = 'Days Mie';
5 $app_list_strings['marker_image_list']['days_jue'] = 'Days Jue';
6 $app_list_strings['marker_image_list']['days_vie'] = 'Days Vie';
7 $app_list_strings['marker_image_list']['days_sab'] = 'Days Sab';