search

jjwilliams42 / generator-aspnet-semanticui

Yeoman ASP.NET Generator with Semantic UI Library
1 stars 2 forks source link

Why not basic web application? #8

Open peterblazejewicz opened 8 years ago

peterblazejewicz commented 8 years ago

The basic web app shares a lot with web application (with authorization). If moved to basic web template, the generator could drop /w semantic ui label and just use yo say to inform that this generator by default uses Semantic UI for client side content when asking questions: https://github.com/yeoman/generator-webapp/blob/master/app/index.js#L60 https://github.com/yeoman/generator-angular/blob/master/app/index.js#L138 This will simplify things for users. Thanks!

jjwilliams42 commented 8 years ago

I'm not familiar with yo say, when is this invoked? By the user at command line?

In my experimental branch I did also convert the basic web app. I will move those changes over and look into this. I still feel it may be good to differentiate the generator in the UI when running.

I'll dig more into yo say.

@peterblazejewicz

peterblazejewicz commented 8 years ago

I think both web application should just use Semantic UI. I'd not add experimental yet, as it complicates things for users. So web-basic template should just also use the same Semantic UI markup/scripts as in web template. Thanks!

jjwilliams42 commented 8 years ago

@peterblazejewicz Yeah I am only going to merge in css / Razor changes for now.

Thanks!

jjwilliams42 commented 8 years ago

@peterblazejewicz By the way, what do you guys use for your IDE for this project? VS Shows errors all over the place with these templates.

peterblazejewicz commented 8 years ago

the generator-aspnet is x-plat and IDE agnostic. It has a .editorconfig file to unify source code formatting: http://editorconfig.org/ The templates comes with EJS Templating markup used by Yeoman - so most of them will render errors, e.g. such lines: https://github.com/jackjwilliams/generator-aspnet-semanticui/blob/master/templates/projects/web/package.json#L4-L11 https://github.com/jackjwilliams/generator-aspnet-semanticui/blob/master/templates/projects/web/Startup.cs#L16 will be rendered with errors in most of editors. The markup/content from aspnet/Templates is taken "as is" and (mostly) not changed at all.