search

jjwilly16 / node-pdftk

A wrapper for PDF Toolkit with streams and promises.
MIT License
139 stars 33 forks source link

Throw helpful error if pdftk binary not installed #11

Closed mattvague closed 6 years ago

mattvague commented 6 years ago

Previously a ENOENT exception was thrown, this is slightly more helpful. The tests don't seem to be passing for me, are they for you @jjwilly16 ?

jjwilly16 commented 6 years ago

This looks good.

Don't be offended, but I'll probably make a few trivial changes later to please my linter. I should just add my .eslintrc to the project - I have it running globally on my system right now. I never even thought to add it - wasn't expecting people to actually use my library lol.

About the tests - they were passing on my work machine, which is windows. When I ran them on my personal linux machine they all failed. Maybe there's some sort of readable difference in the files across the OS platforms. I went ahead and recreated all of the test files manually from my terminal and the tests passed OK.

Which OS are you running?

mattvague commented 6 years ago

@jjwilly16 I'm running mac os x. No worries about changes, thanks for your nice lib!