jjwilly16 / node-pdftk

A wrapper for PDF Toolkit with streams and promises.
MIT License
139 stars 33 forks source link

2.0 - _commandWithStdin style change #17

Closed bsdkurt closed 6 years ago

bsdkurt commented 6 years ago

This is purely a style change so that all the member functions follow the same try/catch pattern. It is not necessary but I thought made the reviewing of the code a bit easier. No worries if you prefer the current implementation as it is good too.

2.0 looks good to me. I don't see anything from a code review standpoint that needs changing. Thanks for making this and the updates.

jjwilly16 commented 6 years ago

Looks good - thanks again!