jk-gan / flipper-plugin-redux-debugger

Flipper plugin for Redux in React Native
MIT License
117 stars 20 forks source link

Generate copyable text lazily to improve performance #22

Closed jeremy-deutsch closed 4 years ago

jeremy-deutsch commented 4 years ago

Right now, copyText is generated for every row in the table on every re-render of ReduxViewer. This is pretty bad for Flipper performance, with re-renders spending 300-500 ms just running buildRow: flipper-performance This PR uses the new Flipper 0.46 feature of generating copyText lazily by passing a function instead of a string, so that now re-renders take very little CPU time: flipper-good-performance

This PR also has some changes to yarn.lock - since the real latest version of Flipper is 0.46, I updated the flipper dependency in the lockfile to 0.46.