search

jk-gan / redux-flipper

Redux middleware for React Native for Flipper
MIT License
160 stars 21 forks source link

Update README.md #28

Closed felippepuhle closed 4 years ago

felippepuhle commented 4 years ago

Is there a reason we need to run yarn add react-native-flipper?

I've spent some time on this issue after updating Flipper to 0.51.0 and just figured out that's the cause.

I just removed from my package.json and the plugin is still working.

Thanks!

jk-gan commented 4 years ago

Hi, we are following Flipper documentation here where it say:

To expose Flipper to the JavaScript world, the React Native Native Module react-native-flipper needs to be installed in the hosting application by running yarn add react-native-flipper and cd ios && pod install. If you are developing a plugin that is distributed as NPM package, make sure to add this to the installation instruction of your package as well!

felippepuhle commented 4 years ago

Oh I see! Thanks for the update!

I'll close this issue then, I've decided to open just in case anyone gets the same error.