search

jk-gan / redux-flipper

Redux middleware for React Native for Flipper
MIT License
158 stars 21 forks source link

resolveCyclic alternative #34

Closed wilau2 closed 3 years ago

wilau2 commented 3 years ago

We have been using react-native-debugger before flipper and the redux-flipper plugin and the behavior is a bit different for the equivalent of the resolveCyclic option.

Instead of including optionally cycle.js they are using jsan and replace the problematic cyclical structure by the "[CIRCULAR]" keyword in the json objects.

Here is the proposed solution

You will end up by having some "modified" payloads logged for the different actions but at least you would see the action.type instead of an error.

I could go ahead and draft a PR if the maintainers of this repo are interested in that solution.

plwai commented 3 years ago

There was a PR #23 about this issue but we could not figure out which action attribute is in cyclic. Now I can see the cyclic part is in the action payload. We will resolve and merge that PR shortly.

plwai commented 3 years ago

close as resolved.

felippepuhle commented 2 years ago

cycle.js also does not have a license which is causing some problems here, would you accept a PR changing it as suggested on this issue @jk-gan @plwai? Thanks!